linux-kernel - Re: [PATCH v4] dt-binding: phy: convert ti,omap-usb2 to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200831111133.GP2639@vkoul-mobl>
Date:   Mon, 31 Aug 2020 16:41:33 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Roger Quadros <rogerq@...com>
Cc:     kishon@...com, Tony Lindgren <tony@...mide.com>,
        robh+dt@...nel.org, nsekhar@...com, vigneshr@...com,
        jan.kiszka@...mens.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v4] dt-binding: phy: convert ti,omap-usb2 to YAML

On 24-08-20, 10:47, Roger Quadros wrote:
> Hi,
> 
> On 21/08/2020 11:11, Roger Quadros wrote:
> > Move ti,omap-usb2 to its own YAML schema.
> > 
> > Signed-off-by: Roger Quadros <rogerq@...com>
> > Reviewed-by: Rob Herring <robh@...nel.org>
> > ---
> > 
> > v4
> > - fix example to fix dt_binding_check warnings
> > - '#phy-cells' -> "#phy-cells"
> > - Add 'oneOf' to compatible logic to allow just "ti,omap-usb2" as valid
> > 
> > v3
> > - Removed quotes from compatibles
> > - changed property to "ti,disable-charger-det"
> > 
> > v2
> > - Address Rob's comments on YAML schema.
> > 
> >   .../devicetree/bindings/phy/ti,omap-usb2.yaml | 72 +++++++++++++++++++
> >   .../devicetree/bindings/phy/ti-phy.txt        | 37 ----------
> >   2 files changed, 72 insertions(+), 37 deletions(-)
> >   create mode 100644 Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml b/Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml
> > new file mode 100644
> > index 000000000000..a05110351814
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml
> > @@ -0,0 +1,72 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/phy/ti,omap-usb2.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: OMAP USB2 PHY
> > +
> > +maintainers:
> > + - Kishon Vijay Abraham I <kishon@...com>
> > + - Roger Quadros <rogerq@...com>
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +        - enum:
> > +          - ti,dra7x-usb2
> > +          - ti,dra7x-usb2-phy2
> > +          - ti,am654-usb2
> 
> I missed these two.
> "ti,omap5-usb2"
> "ti,am437x-usb2"
> 
> While "ti,am437x-usb2" is being used in the device tree files
> I don't see "ti,omap5-usb2" being used anywhere.
> 
> omap5-l4.dtsi uses "ti,omap-usb2"
> 
> Should we get rid of "ti,omap5-usb2"?

Sure drop them ;-) we can always add back when we have a user

-- 
~Vinod