linux-kernel - Re: [RFT 2/4] ARM: dts: exynos: Move fixed clocks under root node in Exynos3250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Aug 2020 13:03:19 +0200
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Hoegeun Kwon <hoegeun.kwon@...sung.com>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Sylwester Nawrocki <snawrocki@...nel.org>
Subject: Re: [RFT 2/4] ARM: dts: exynos: Move fixed clocks under root node
 in Exynos3250

On 29.08.2020 19:25, Krzysztof Kozlowski wrote:
> The fixed clocks are kept under dedicated node fixed-rate-clocks, thus a
> fake "reg" was added.  This is not correct with dtschema as fixed-clock
> binding does not have a "reg" property:
>
>    arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock@0: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
Tested-by: Marek Szyprowski <m.szyprowski@...sung.com>
> ---
>   arch/arm/boot/dts/exynos3250.dtsi | 42 +++++++++++++------------------
>   1 file changed, 17 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
> index d3fb45a56527..c67c70e46794 100644
> --- a/arch/arm/boot/dts/exynos3250.dtsi
> +++ b/arch/arm/boot/dts/exynos3250.dtsi
> @@ -97,33 +97,25 @@
>   		};
>   	};
>   
> -	fixed-rate-clocks {
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -
> -		xusbxti: clock@0 {
> -			compatible = "fixed-clock";
> -			reg = <0>;
> -			clock-frequency = <0>;
> -			#clock-cells = <0>;
> -			clock-output-names = "xusbxti";
> -		};
> +	xusbxti: clock-0 {
> +		compatible = "fixed-clock";
> +		clock-frequency = <0>;
> +		#clock-cells = <0>;
> +		clock-output-names = "xusbxti";
> +	};
>   
> -		xxti: clock@1 {
> -			compatible = "fixed-clock";
> -			reg = <1>;
> -			clock-frequency = <0>;
> -			#clock-cells = <0>;
> -			clock-output-names = "xxti";
> -		};
> +	xxti: clock-1 {
> +		compatible = "fixed-clock";
> +		clock-frequency = <0>;
> +		#clock-cells = <0>;
> +		clock-output-names = "xxti";
> +	};
>   
> -		xtcxo: clock@2 {
> -			compatible = "fixed-clock";
> -			reg = <2>;
> -			clock-frequency = <0>;
> -			#clock-cells = <0>;
> -			clock-output-names = "xtcxo";
> -		};
> +	xtcxo: clock-2 {
> +		compatible = "fixed-clock";
> +		clock-frequency = <0>;
> +		#clock-cells = <0>;
> +		clock-output-names = "xtcxo";
>   	};
>   
>   	pmu {

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland