linux-kernel - Re: [PATCH] net: ipv4: remove unused arg exact_dif in compute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7244626ca1494044bdd44c8269cfda91@huawei.com>
Date:   Mon, 31 Aug 2020 01:25:54 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     David Ahern <dsahern@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuznet@....inr.ac.ru" <kuznet@....inr.ac.ru>,
        "yoshfuji@...ux-ipv6.org" <yoshfuji@...ux-ipv6.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: ipv4: remove unused arg exact_dif in compute_score

David Ahern <dsahern@...il.com> wrote:
>On 8/29/20 3:01 AM, Miaohe Lin wrote:
>> @@ -277,15 +277,13 @@ static struct sock *inet_lhash2_lookup(struct net *net,
>>  				const __be32 daddr, const unsigned short hnum,
>>  				const int dif, const int sdif)
>>  {
>> -	bool exact_dif = inet_exact_dif_match(net, skb);
>
>inet_exact_dif_match is no longer needed after the above is removed.

Oh, I missed it. Will remove inet_exact_dif_match() in v2. Many thanks for review and reply.