linux-kernel - RE: [EXT] [PATCH] scsi: qla2xxx: Fix the return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR18MB3052E1B8F65AA24F80530E37AF510@DM6PR18MB3052.namprd18.prod.outlook.com>
Date:   Mon, 31 Aug 2020 11:41:26 +0000
From:   Nilesh Javali <njavali@...vell.com>
To:     Xianting Tian <tian.xianting@....com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qla2xxx: Fix the return value

Xianting Tian,

Thanks for the patch.

> -----Original Message-----
> From: Xianting Tian <tian.xianting@....com>
> Sent: Saturday, August 29, 2020 1:28 PM
> To: Nilesh Javali <njavali@...vell.com>; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@...vell.com>; jejb@...ux.ibm.com;
> martin.petersen@...cle.com
> Cc: linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; Xianting Tian
> <tian.xianting@....com>
> Subject: [EXT] [PATCH] scsi: qla2xxx: Fix the return value
> 
> External Email
> 
> ----------------------------------------------------------------------
> A negative error code should be returned.
> 
> Signed-off-by: Xianting Tian <tian.xianting@....com>
> ---
>  drivers/scsi/qla2xxx/qla_target.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_target.c
> b/drivers/scsi/qla2xxx/qla_target.c
> index fbb80a043..612e001cc 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd)
>  		    "multiple abort. %p transport_state %x, t_state %x, "
>  		    "se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state,
>  		    cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags);
> -		return EIO;
> +		return -EIO;
>  	}
>  	cmd->aborted = 1;
>  	cmd->trc_flags |= TRC_ABORT;
> --
> 2.17.1

Acked-by: Nilesh Javali <njavali@...vell.com>