linux-kernel - Re: [PATCH] mtd: ck804xrom: fix missing pci device put in error paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 31 Aug 2020 14:00:32 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     James Bond <jameslouisebond@...il.com>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Arnd Bergmann <arnd@...db.de>,
        Ryan Jackson <rjackson@...i.com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] mtd: ck804xrom: fix missing pci device put in error
 paths

Hi James,

James Bond <jameslouisebond@...il.com> wrote on Fri, 28 Aug 2020
21:28:40 -0500:

> Hi Miquèl,
> Thanks for your feedback.
> I have just rechecked this function and find that "pdev" currently is
> already put
> inside ck804xrom_cleanup, so my previous patch is meaningless...
> The current calling order is like:
> 
> window->pdev = pci_dev_get(pdev);
> ...
>     ck804xrom_cleanup(window)
>              ->  
>                   pci_dev_put(window->pdev);
> And sorry for bothering you.

Ok that's fine, thanks anyway!

Miquèl