linux-kernel - Re: [PATCH] microblaze: fix min_low_pfn/max_low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fca6486a-5e6b-1ad4-1a52-aec674a67223@monstr.eu>
Date:   Mon, 31 Aug 2020 16:04:56 +0200
From:   Michal Simek <monstr@...str.eu>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     kernel test robot <lkp@...el.com>, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Rientjes <rientjes@...gle.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Michal Simek <monstr@...str.eu>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH] microblaze: fix min_low_pfn/max_low_pfn build errors

Hi,

On 29. 08. 20 2:01, Randy Dunlap wrote:
> Fix min_low_pfn/max_low_pfn build errors for arch/microblaze/: (e.g.)
> 
>   ERROR: "min_low_pfn" [drivers/rpmsg/virtio_rpmsg_bus.ko] undefined!
>   ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu_sink.ko] undefined!
>   ERROR: "min_low_pfn" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
>   ERROR: "min_low_pfn" [drivers/mmc/core/mmc_core.ko] undefined!
>   ERROR: "min_low_pfn" [drivers/md/dm-crypt.ko] undefined!
>   ERROR: "min_low_pfn" [drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko] undefined!
>   ERROR: "min_low_pfn" [crypto/tcrypt.ko] undefined!
>   ERROR: "min_low_pfn" [crypto/asymmetric_keys/asym_tpm.ko] undefined!
> 
> Mike had/has an alternate patch for Microblaze:
> https://lore.kernel.org/lkml/20200630111519.GA1951986@linux.ibm.com/
> 
> David suggested just exporting min_low_pfn & max_low_pfn in
> mm/memblock.c:
> https://lore.kernel.org/lkml/alpine.DEB.2.22.394.2006291911220.1118534@chino.kir.corp.google.com/
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: linux-mm@...ck.org
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: David Rientjes <rientjes@...gle.com>
> Cc: Mike Rapoport <rppt@...ux.ibm.com>
> Cc: Michal Simek <monstr@...str.eu>
> Cc: Michal Simek <michal.simek@...inx.com>
> ---
>  arch/microblaze/mm/init.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> --- linux-next-20200825.orig/arch/microblaze/mm/init.c
> +++ linux-next-20200825/arch/microblaze/mm/init.c
> @@ -46,6 +46,9 @@ unsigned long memory_size;
>  EXPORT_SYMBOL(memory_size);
>  unsigned long lowmem_size;
>  
> +EXPORT_SYMBOL(min_low_pfn);
> +EXPORT_SYMBOL(max_low_pfn);
> +
>  #ifdef CONFIG_HIGHMEM
>  pte_t *kmap_pte;
>  EXPORT_SYMBOL(kmap_pte);
> 

Acked-by: Michal Simek <monstr@...str.eu>

Mike: Feel free to take it via memblock tree as you mentioned in
alternate patch.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs