linux-kernel - Re: [PATCH] infiniband: remove unnecessary fallthrough usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33b7fe93c7fd17658baeabd233d38099@kernel.wtf>
Date:   Mon, 31 Aug 2020 19:00:32 +0300
From:   Cengiz Can <cengiz@...nel.wtf>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Dennis Dalessandro <dennis.dalessandro@...el.com>,
        Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        "Gustavo A . R . Silva" <gustavoars@...nel.org>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] infiniband: remove unnecessary fallthrough usage

On 2020-08-31 18:34, Jason Gunthorpe wrote:
> On Mon, Aug 31, 2020 at 06:30:34PM +0300, Cengiz Can wrote:
>> Since /* fallthrough */ comments are deprecated[1], they are being 
>> replaced
>> by new 'fallthrough' pseudo-keyword.
>> 
>> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\
>>         highlight=fallthrough#implicit-switch-case-fall-through
>> 
>> This sometimes leads to unreachable code warnings by static analyzers,
>> particularly in this case, Coverity Scanner. (CID 1466512)
>> 
>> Remove unnecessary 'fallthrough' keywords to prevent dead code
>> warnings.
>> 
>> Signed-off-by: Cengiz Can <cengiz@...nel.wtf>
>> ---
>>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>>  1 file changed, 2 deletions(-)
> 
> Alex beat you to it:
> 
> https://patchwork.kernel.org/patch/11736039/

Well, I'm glad it's fixed :)

Thanks for sharing

> 
> Thanks,
> Jason

-- 
Cengiz Can
@cengiz_io