linux-kernel - Re: [PATCH] SELinux: Measure state and hash of policy using IMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <612ec12d-0048-2a5f-83a5-518a11eb546d@linux.microsoft.com>
Date:   Mon, 31 Aug 2020 09:39:08 -0700
From:   Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
To:     Stephen Smalley <stephen.smalley.work@...il.com>
Cc:     Paul Moore <paul@...l-moore.com>,
        Ondrej Mosnacek <omosnace@...hat.com>,
        Mimi Zohar <zohar@...ux.ibm.com>,
        Casey Schaufler <casey@...aufler-ca.com>,
        Tyler Hicks <tyhicks@...ux.microsoft.com>,
        tusharsu@...ux.microsoft.com, Sasha Levin <sashal@...nel.org>,
        James Morris <jmorris@...ei.org>,
        linux-integrity@...r.kernel.org,
        SElinux list <selinux@...r.kernel.org>,
        LSM List <linux-security-module@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] SELinux: Measure state and hash of policy using IMA

On 8/31/20 7:47 AM, Stephen Smalley wrote:

>>>>
>>>
>>> Could you please let me know when the current set of changes in SELinux
>>> next branch would be completed and be ready to take new changes?
>>>
>>> I mean, roughly - would it be a month from now or you expect that to
>>> take longer?
>>
>> I can't speak for Paul but I would expect it to be sooner rather than
>> later. Ondrej has some follow ups on top of my policy rcu conversion
>> but then it should be good to go.
> 
> I think the major changes are now merged although there are still a
> couple of changes coming from Ondrej that could affect your code.  For
> your purposes, the important things to note are:
> 
> 1) The mutex has moved from selinux_fs_info to selinux_state and is
> now named policy_mutex.  You will need to take it around your call to
> security_read_policy_kernel().
> 
> 2) security_policydb_len() was removed and security_read_policy() just
> directly reads the policydb len.  You can do the same from your
> security_read_policy_kernel() variant.
> 
> 3) Ondrej has a pending change to move the policycap[] array from
> selinux_state to selinux_policy so that it can be atomically updated
> with the policy.
> 
> 4) Ondrej has a pending change to eliminate the separate initialized
> boolean from selinux_state and just test whether selinux_state.policy
> is non-NULL but as long as you are using selinux_initialized() to
> test, your code should be unaffected.
> 

Thanks a lot for the update Stephen.

I will start updating the IMA measurement changes in selinux next 
branch. Will post the patches this week.

  -lakshmi