linux-kernel - Re: [PATCH] fat: Avoid oops when bdi->io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200831165659.GH14765@casper.infradead.org>
Date:   Mon, 31 Aug 2020 17:56:59 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] fat: Avoid oops when bdi->io_pages==0

On Mon, Aug 31, 2020 at 10:39:26AM -0600, Jens Axboe wrote:
> We really should ensure that ->io_pages is always set, imho, instead of
> having to work-around it in other spots.

Interestingly, there are only three places in the entire kernel which
_use_ bdi->io_pages.  FAT, Verity and the pagecache readahead code.

Verity:
                        unsigned long num_ra_pages =
                                min_t(unsigned long, num_blocks_to_hash - i,
                                      inode->i_sb->s_bdi->io_pages);

FAT:
        if (ra_pages > sb->s_bdi->io_pages)
                ra_pages = rounddown(ra_pages, sb->s_bdi->io_pages);

Pagecache:
        max_pages = max_t(unsigned long, bdi->io_pages, ra->ra_pages);
and
        if (req_size > max_pages && bdi->io_pages > max_pages)
                max_pages = min(req_size, bdi->io_pages);

The funny thing is that all three are using it differently.  Verity is
taking io_pages to be the maximum amount to readahead.  FAT is using
it as the unit of readahead (round down to the previous multiple) and
the pagecache uses it to limit reads that exceed the current per-file
readahead limit (but allows per-file readahead to exceed io_pages,
in which case it has no effect).

So how should it be used?  My inclination is to say that the pagecache
is right, by virtue of being the most-used.