linux-kernel - Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2 HD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200831192617.3af13f1b@aktux>
Date:   Mon, 31 Aug 2020 19:26:17 +0200
From:   Andreas Kemnade <andreas@...nade.info>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     robh+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
        kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        Anson.Huang@....com, marcel.ziswiler@...adex.com,
        sebastien.szymanski@...adeus.com, michael@...le.cc,
        rjones@...eworks.com, leoyang.li@....com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2
 HD

Hi,

On Thu, 27 Aug 2020 20:33:23 +0200
Jonathan Neuschäfer <j.neuschaefer@....net> wrote:

> On Wed, Aug 26, 2020 at 10:42:51PM +0200, Andreas Kemnade wrote:
> > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is based
> > on boards marked with "37NB-E60QF0+4A2". It is equipped with an i.MX6SL
> > SoC.
> > 
> > Expected to work:
> > - Buttons
> > - Wifi
> > - Touchscreen
> > - LED
> > - uSD
> > - USB
> > - RTC
> > 
> > Not working due to missing drivers:
> > - Backlight (requires NTXEC driver)
> > - EPD
> > 
> > Not working due to unknown reasons:
> > - deep sleep (echo standby >/sys/power/state works),
> >   wakeup fails when imx_gpc_pre_suspend(true) was called.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> > ---  
> [...]
> > +		fl {
> > +			label = "Frontlight";
> > +			gpios = <&gpio3 26 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_BRIGHTNESS_CYCLE>;
> > +		};  
> 
> Another option might be KEY_BRIGHTNESS_TOGGLE/KEY_DISPLAYTOGGLE, but
> it's not a perfect match, either. (And perhaps a worse match due to the
> connotation of turning the display off.)
> 
I have also thought about these, but came to the same conclusion as you,
the connotation of turning the display off does not feel right.

> 
> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> 
> Thanks

Regards,
Andreas