lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Sep 2020 08:49:52 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Krzysztof Kozlowski <krzk@...nel.org> Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>, linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] watchdog: cadence: Simplify with dev_err_probe() On Tue, Sep 01, 2020 at 05:31:39PM +0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org> Reviewed-by: Guenter Roeck <linux@...ck-us.net> > --- > drivers/watchdog/cadence_wdt.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c > index 672b184da875..bc99e9164930 100644 > --- a/drivers/watchdog/cadence_wdt.c > +++ b/drivers/watchdog/cadence_wdt.c > @@ -334,12 +334,9 @@ static int cdns_wdt_probe(struct platform_device *pdev) > watchdog_set_drvdata(cdns_wdt_device, wdt); > > wdt->clk = devm_clk_get(dev, NULL); > - if (IS_ERR(wdt->clk)) { > - ret = PTR_ERR(wdt->clk); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "input clock not found\n"); > - return ret; > - } > + if (IS_ERR(wdt->clk)) > + return dev_err_probe(dev, PTR_ERR(wdt->clk), > + "input clock not found\n"); > > ret = clk_prepare_enable(wdt->clk); > if (ret) { > -- > 2.17.1 >
Powered by blists - more mailing lists