linux-kernel - Re: [PATCH] pktgen: fix error message with wrong function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200901172556.GA31464@embeddedor>
Date:   Tue, 1 Sep 2020 12:25:56 -0500
From:   "Gustavo A. R. Silva" <gustavoars@...nel.org>
To:     Leesoo Ahn <dev@...eel.net>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Lukas Wunner <lukas@...ner.de>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Niu Xilei <niu_xilei@....com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pktgen: fix error message with wrong function name

On Tue, Sep 01, 2020 at 10:04:47PM +0900, Leesoo Ahn wrote:
> Error on calling kthread_create_on_node prints wrong function name,
> kernel_thread.
> 
> Signed-off-by: Leesoo Ahn <dev@...eel.net>

You might need to add the following tag:

Fixes: 94dcf29a11b3 ("kthread: use kthread_create_on_node()")

Acked-by: Gustavo A. R. Silva <gustavoars@...nel.org>

Thanks
--
Gustavo

> ---
>  net/core/pktgen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index 95f4c6b8f51a..44fdbb9c6e53 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -3699,7 +3699,7 @@ static int __net_init pktgen_create_thread(int cpu, struct pktgen_net *pn)
>  				   cpu_to_node(cpu),
>  				   "kpktgend_%d", cpu);
>  	if (IS_ERR(p)) {
> -		pr_err("kernel_thread() failed for cpu %d\n", t->cpu);
> +		pr_err("kthread_create_on_node() failed for cpu %d\n", t->cpu);
>  		list_del(&t->th_list);
>  		kfree(t);
>  		return PTR_ERR(p);
> -- 
> 2.25.4
>