linux-kernel - Re: [PATCH v5 00/21] kprobes: Unify kretprobe trampoline handlers and make kretprobe lockless

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200901190808.GK29142@worktop.programming.kicks-ass.net>
Date:   Tue, 1 Sep 2020 21:08:08 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Eddy_Wu@...ndmicro.com,
        x86@...nel.org, davem@...emloft.net, rostedt@...dmis.org,
        naveen.n.rao@...ux.ibm.com, anil.s.keshavamurthy@...el.com,
        linux-arch@...r.kernel.org, cameron@...dycamel.com,
        oleg@...hat.com, will@...nel.org, paulmck@...nel.org
Subject: Re: [PATCH v5 00/21] kprobes: Unify kretprobe trampoline handlers
 and make kretprobe lockless

On Sat, Aug 29, 2020 at 09:59:49PM +0900, Masami Hiramatsu wrote:
> Masami Hiramatsu (16):
>       kprobes: Add generic kretprobe trampoline handler
>       x86/kprobes: Use generic kretprobe trampoline handler
>       arm: kprobes: Use generic kretprobe trampoline handler
>       arm64: kprobes: Use generic kretprobe trampoline handler
>       arc: kprobes: Use generic kretprobe trampoline handler
>       csky: kprobes: Use generic kretprobe trampoline handler
>       ia64: kprobes: Use generic kretprobe trampoline handler
>       mips: kprobes: Use generic kretprobe trampoline handler
>       parisc: kprobes: Use generic kretprobe trampoline handler
>       powerpc: kprobes: Use generic kretprobe trampoline handler
>       s390: kprobes: Use generic kretprobe trampoline handler
>       sh: kprobes: Use generic kretprobe trampoline handler
>       sparc: kprobes: Use generic kretprobe trampoline handler
>       kprobes: Remove NMI context check
>       kprobes: Free kretprobe_instance with rcu callback
>       kprobes: Make local used functions static
> 
> Peter Zijlstra (5):
>       llist: Add nonatomic __llist_add() and __llist_dell_all()
>       kprobes: Remove kretprobe hash
>       asm-generic/atomic: Add try_cmpxchg() fallbacks
>       freelist: Lock less freelist
>       kprobes: Replace rp->free_instance with freelist

This looks good to me, do you want me to merge them through -tip? If so,
do we want to try and get them in this release still?

Ingo, opinions? This basically fixes a regression cauesd by

  0d00449c7a28 ("x86: Replace ist_enter() with nmi_enter()")