linux-kernel - Re: [linux-next PATCH v3] drivers/virt/fsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10705531-7a03-44d9-3fc7-e520a7b1cd87@nvidia.com>
Date:   Tue, 1 Sep 2020 13:52:06 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Dan Williams <dan.j.williams@...el.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, <timur@...escale.com>,
        <galak@...nel.crashing.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [linux-next PATCH v3] drivers/virt/fsl_hypervisor: Fix error
 handling path

On 9/1/20 1:14 PM, Souptick Joarder wrote:
> Hi John,
> 
> On Tue, Sep 1, 2020 at 4:28 AM John Hubbard <jhubbard@...dia.com> wrote:
>>
>> On 8/31/20 3:07 PM, Souptick Joarder wrote:
>>> First, when memory allocation for sg_list_unaligned failed, there
>>> is a bug of calling put_pages() as we haven't pinned any pages.
>>
>> "we should unpin"
> 
> will it be "we shouldn't unpin" ? can you please clarify this ?

Whoops, I put my comment next to the wrong part of your email. Sorry
about that! It was supposed to be a correction to this sentence:

"
Second, if get_user_pages_fast() failed we should unpinned num_pinned
pages instead of checking till num_pages.
"

...which I wanted to change to:


Second, if get_user_pages_fast() failed we should unpin num_pinned pages
instead of checking till num_pages.

thanks,
-- 
John Hubbard
NVIDIA