linux-kernel - Re: [PATCH] x86/platform/intel-mid: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d686f3f-b4ee-70e0-3050-1eb6d060ffc3@huawei.com>
Date:   Tue, 1 Sep 2020 14:17:27 +0800
From:   Yuehaibing <yuehaibing@...wei.com>
To:     Randy Dunlap <rdunlap@...radead.org>, <bhelgaas@...gle.com>,
        <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
        <x86@...nel.org>, <hpa@...or.com>, <efremov@...ux.com>,
        <andriy.shevchenko@...ux.intel.com>
CC:     <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/platform/intel-mid: Fix build error without
 CONFIG_ACPI

On 2020/9/1 12:07, Randy Dunlap wrote:
> On 8/31/20 8:58 PM, YueHaibing wrote:
>> arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
>> arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? [-Werror=implicit-function-declaration]
>>   acpi_noirq_set();
>>   ^~~~~~~~~~~~~~
>>   acpi_irq_get
>>
>> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to arch_init()")
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Bjorn has merged my patch (or so his email says), but apparently it's not
> in linux-next yet.

Thanks for info.

> 
> 
>> ---
>>  arch/x86/pci/intel_mid_pci.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
>> index 00c62115f39c..0aaf31917061 100644
>> --- a/arch/x86/pci/intel_mid_pci.c
>> +++ b/arch/x86/pci/intel_mid_pci.c
>> @@ -33,6 +33,7 @@
>>  #include <asm/hw_irq.h>
>>  #include <asm/io_apic.h>
>>  #include <asm/intel-mid.h>
>> +#include <asm/acpi.h>
>>  
>>  #define PCIE_CAP_OFFSET	0x100
>>  
>>
> 
> thanks.
>