linux-kernel - Re: [PATCH] [v2] HID: elan: Fix memleak in elan_input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Sep 2020 09:13:20 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
cc:     kjlu@....edu, Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] HID: elan: Fix memleak in elan_input_configured

On Mon, 31 Aug 2020, Dinghao Liu wrote:

> When input_mt_init_slots() fails, input should be freed
> to prevent memleak. When input_register_device() fails,
> we should call input_mt_destroy_slots() to free memory
> allocated by input_mt_init_slots().
> 
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---
> 
> Changelog:
> 
> v2: - Add input_mt_destroy_slots() on failure of
>       input_register_device().

Thanks, applied.

-- 
Jiri Kosina
SUSE Labs