linux-kernel - Re: [PATCH] HID: core: Correctly handle ReportSize being zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2009011013400.4671@cbobk.fhfr.pm>
Date:   Tue, 1 Sep 2020 10:14:15 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Marc Zyngier <maz@...nel.org>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH] HID: core: Correctly handle ReportSize being zero

On Sat, 29 Aug 2020, Marc Zyngier wrote:

> It appears that a ReportSize value of zero is legal, even if a bit
> non-sensical. Most of the HID code seems to handle that gracefully,
> except when computing the total size in bytes. When fed as input to
> memset, this leads to some funky outcomes.
> 
> Detect the corner case and correctly compute the size.
> 
> Cc: stable@...r.kernel.org
> Signed-off-by: Marc Zyngier <maz@...nel.org>

Thanks Marc; Benjamin will be pushing this patch through his regression 
testing machinery, and if all is good, I'll push it for 5.9-rc still.

-- 
Jiri Kosina
SUSE Labs