linux-kernel - Re: [PATCH] EDAC: i5100_edac: Fix error handling code in i5100_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200901101345.GA8392@zn.tnic>
Date:   Tue, 1 Sep 2020 12:13:45 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rrichter@...vell.com>,
        Niklas Söderlund <niklas.soderlund@...csson.com>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC: i5100_edac: Fix error handling code in
 i5100_init_one

On Wed, Aug 26, 2020 at 08:14:37PM +0800, Dinghao Liu wrote:
> When pci_get_device_func() fails, we don't need to execute
> pci_dev_put(). But mci should be freed to prevent memleak.
> When pci_enable_device() fails, we don't need to disable
> einj either.
> 
> Fixes: 52608ba205461 ("i5100_edac: probe for device 19 function 0")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---
>  drivers/edac/i5100_edac.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette