linux-kernel - Re: [PATCH] signal: clean up codestyle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1461a6c6bfe34ae9a5220a7d47d304e8@huawei.com>
Date:   Tue, 1 Sep 2020 12:47:17 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Christian Brauner <christian.brauner@...ntu.com>
CC:     "oleg@...hat.com" <oleg@...hat.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "madhuparnabhowmik10@...il.com" <madhuparnabhowmik10@...il.com>,
        "gustavoars@...nel.org" <gustavoars@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] signal: clean up codestyle

Christian Brauner <christian.brauner@...ntu.com> wrote:
> On Tue, Sep 01, 2020 at 07:58:00AM -0400, Miaohe Lin wrote:
> No functional change intended.

>Hey Miaohe,
>
>Thank you for the patch.
>I'm sure this is well-intended but afaict the whole file has more or less a consistent style already where e.g. sig-1 without spaces seems to be preferred. The same for the casts where most places use a single space.
>
>Now, I know CodingStyle.rst is on your side at least when it comes to the first point:
>
>Use one space around (on each side of) most binary and ternary operators, such as any of these::
>
>	=  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=  ?  :
>
>but then you'd need to change each place in kernel/signal.c where that is currently not the case. Otherwise we end up with a weird mix.
>
>Thanks!
>Christian
> 

Many thanks for your reply. It looks it's better to make codestyle consistent. Will do it when I'am free. :)
Thanks again.