linux-kernel - RE: Re: [PATCH 1/2] ARM: dts: imx6qp-sabresd: enable pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB585346A768355281ECD20D118C2E0@VI1PR04MB5853.eurprd04.prod.outlook.com>
Date:   Tue, 1 Sep 2020 02:51:28 +0000
From:   Richard Zhu <hongxing.zhu@....com>
To:     Lucas Stach <l.stach@...gutronix.de>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "festevam@...il.com" <festevam@...il.com>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE:  Re: [PATCH 1/2] ARM: dts: imx6qp-sabresd: enable pcie

> -----Original Message-----
> From: Lucas Stach <l.stach@...gutronix.de>
> Sent: 2020年7月21日 16:16
> To: Richard Zhu <hongxing.zhu@....com>; bhelgaas@...gle.com;
> shawnguo@...nel.org; festevam@...il.com
> Cc: linux-pci@...r.kernel.org; dl-linux-imx <linux-imx@....com>;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> kernel@...gutronix.de
> Subject: [EXT] Re: [PATCH 1/2] ARM: dts: imx6qp-sabresd: enable pcie
> 
> Caution: EXT Email
> 
> Am Dienstag, den 21.07.2020, 15:44 +0800 schrieb Richard Zhu:
> > Add one regulator, used to power up the external oscillator, and
> > enable PCIe on iMX6QP SABRESD board.
> 
> That's not the right thing to do. If there is an external oscillator, which requires a
> power supply then the oscillator should have its own clock DT node (it's a
> separate device after all) and this node needs to control the regulator.
> 
> This has nothing to do with the PCIe controller, which only cares about the clock
> being provided.
> 
To be simple, and easy to maintain. How about to set the vgen3 always on in this case?

Best Regards
Richard Zhu

> Regards,
> Lucas
> 
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > ---
> >  arch/arm/boot/dts/imx6qp-sabresd.dts | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qp-sabresd.dts
> > b/arch/arm/boot/dts/imx6qp-sabresd.dts
> > index 480e73183f6b..cd8a1f610427 100644
> > --- a/arch/arm/boot/dts/imx6qp-sabresd.dts
> > +++ b/arch/arm/boot/dts/imx6qp-sabresd.dts
> > @@ -51,7 +51,8 @@
> >  };
> >
> >  &pcie {
> > -     status = "disabled";
> > +     vepdev-supply = <&vgen3_reg>;
> > +     status = "okay";
> >  };
> >
> >  &sata {