linux-kernel - Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60e6b790-360a-6eaf-03a3-5bb256adf215@ti.com>
Date:   Wed, 2 Sep 2020 11:51:03 -0500
From:   Suman Anna <s-anna@...com>
To:     Nishanth Menon <nm@...com>, Rob Herring <robh+dt@...nel.org>,
        Tero Kristo <t-kristo@...com>
CC:     <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Vignesh Raghavendra <vigneshr@...com>, <lokeshvutla@...com>,
        <grygorii.strashko@...com>, <nsekhar@...com>
Subject: Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names

On 9/1/20 5:30 PM, Nishanth Menon wrote:
> Use adc@ naming for nodes following standard conventions of device
> tree (section 2.2.2 Generic Names recommendation in [1]).
> 
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
> 
> Suggested-by: Suman Anna <s-anna@...com>
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
>  arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index 51ca4b4d4c21..6dfec68ac865 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -80,7 +80,7 @@
>  		#size-cells = <0>;
>  	};
>  
> -	tscadc0: tscadc@...00000 {
> +	tscadc0: adc@...00000 {

OK with these changes, since these seem to be only have the adc child nodes.
This node is essentially a parent node for touchscreen and adc child nodes. The
driver is currently looking for "tsc" on touchscreen child nodes, but none of
the K3 SoCs have them atm.

regards
Suman

>  		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
>  		reg = <0x0 0x40200000 0x0 0x1000>;
>  		interrupts = <GIC_SPI 580 IRQ_TYPE_LEVEL_HIGH>;
> @@ -98,7 +98,7 @@
>  		};
>  	};
>  
> -	tscadc1: tscadc@...10000 {
> +	tscadc1: adc@...10000 {
>  		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
>  		reg = <0x0 0x40210000 0x0 0x1000>;
>  		interrupts = <GIC_SPI 581 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index 9ad0266598ad..81801f519a61 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -211,7 +211,7 @@
>  		};
>  	};
>  
> -	tscadc0: tscadc@...00000 {
> +	tscadc0: adc@...00000 {
>  		compatible = "ti,am3359-tscadc";
>  		reg = <0x0 0x40200000 0x0 0x1000>;
>  		interrupts = <GIC_SPI 860 IRQ_TYPE_LEVEL_HIGH>;
> @@ -230,7 +230,7 @@
>  		};
>  	};
>  
> -	tscadc1: tscadc@...10000 {
> +	tscadc1: adc@...10000 {
>  		compatible = "ti,am3359-tscadc";
>  		reg = <0x0 0x40210000 0x0 0x1000>;
>  		interrupts = <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>;
>