linux-kernel - Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Sep 2020 11:55:56 -0500
From:   Suman Anna <s-anna@...com>
To:     Nishanth Menon <nm@...com>, Rob Herring <robh+dt@...nel.org>,
        Tero Kristo <t-kristo@...com>, "J, KEERTHY" <j-keerthy@...com>
CC:     <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Vignesh Raghavendra <vigneshr@...com>, <lokeshvutla@...com>,
        <grygorii.strashko@...com>, <nsekhar@...com>
Subject: Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic
 temperature-sensor for node name

On 9/1/20 5:30 PM, Nishanth Menon wrote:
> Use temperature-sensor@ naming for nodes following standard conventions of device
> tree (section 2.2.2 Generic Names recommendation in [1]).
> 
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
> 
> Suggested-by: Suman Anna <s-anna@...com>
> Suggested-by: Vignesh Raghavendra <vigneshr@...com>
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> index bb498be2f0a4..ed42f13e7663 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> @@ -95,7 +95,7 @@
>  		clock-names = "gpio";
>  	};
>  
> -	wkup_vtm0: thermal@...50000 {
> +	wkup_vtm0: temperature-sensor@...50000 {

There has been a suggestion to use something like thermal-sensor during the
bindings review, but it is better to use this standard node name.

Reviewed-by: Suman Anna <s-anna@...com>

regards
Suman

>  		compatible = "ti,am654-vtm";
>  		reg = <0x42050000 0x25c>;
>  		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
>