linux-kernel - Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic temperature-sensor for node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200902181439.ywzxknv3vb7fcfeo@akan>
Date:   Wed, 2 Sep 2020 13:14:39 -0500
From:   Nishanth Menon <nm@...com>
To:     Suman Anna <s-anna@...com>
CC:     Rob Herring <robh+dt@...nel.org>, Tero Kristo <t-kristo@...com>,
        "J, KEERTHY" <j-keerthy@...com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Vignesh Raghavendra <vigneshr@...com>, <lokeshvutla@...com>,
        <grygorii.strashko@...com>, <nsekhar@...com>
Subject: Re: [PATCH 5/7] arm64: dts: ti: k3-am65-wakeup: Use generic
 temperature-sensor for node name

On 11:55-20200902, Suman Anna wrote:
> On 9/1/20 5:30 PM, Nishanth Menon wrote:
> > Use temperature-sensor@ naming for nodes following standard conventions of device
> > tree (section 2.2.2 Generic Names recommendation in [1]).
> > 
> > [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
> > 
> > Suggested-by: Suman Anna <s-anna@...com>
> > Suggested-by: Vignesh Raghavendra <vigneshr@...com>
> > Signed-off-by: Nishanth Menon <nm@...com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > index bb498be2f0a4..ed42f13e7663 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-wakeup.dtsi
> > @@ -95,7 +95,7 @@
> >  		clock-names = "gpio";
> >  	};
> >  
> > -	wkup_vtm0: thermal@...50000 {
> > +	wkup_vtm0: temperature-sensor@...50000 {
> 
> There has been a suggestion to use something like thermal-sensor during the
> bindings review, but it is better to use this standard node name.

Yes - I did notice it as well, and then picked up the recommendation
straight from 0.3 spec itself.
> 
> Reviewed-by: Suman Anna <s-anna@...com>
> 
> regards
> Suman
> 
> >  		compatible = "ti,am654-vtm";
> >  		reg = <0x42050000 0x25c>;
> >  		power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
> > 
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D