linux-kernel - Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b82468b-bc67-df62-1816-1f510888fc39@redhat.com>
Date:   Wed, 2 Sep 2020 11:40:10 -0700
From:   Tom Rix <trix@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     pshelar@....org, kuba@...nel.org, natechancellor@...il.com,
        ndesaulniers@...gle.com, netdev@...r.kernel.org,
        dev@...nvswitch.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: openvswitch: pass NULL for unused parameters


On 9/1/20 1:11 PM, David Miller wrote:
> From: trix@...hat.com
> Date: Sun, 30 Aug 2020 14:26:30 -0700
>
>> Passing unused parameters is a waste.
> Poorly predicted branches are an even bigger waste.
>
> I'm not a big fan of this change and others have asked for performance
> analysis to be performed.
>
> So I'm not applying this as-is, sorry.

no worries.

I think these functions need a larger working over so the stats collecting are not in the core functions.

Thanks for giving it a look,

Tom

>
> It's also not great to see that CLANG can't make use of the caller's
> __always_unused directive to guide these warnings.