linux-kernel - Re: [PATCH] RDMA/ucma: fix memory leak of mc on an xa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a86f5b1b-29f8-991f-a46b-fabc3566b15d@canonical.com>
Date:   Wed, 2 Sep 2020 20:39:23 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Markus Elfring <Markus.Elfring@....de>, linux-rdma@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH] RDMA/ucma: fix memory leak of mc on an xa_alloc failure

On 02/09/2020 20:03, Markus Elfring wrote:
>> Currently when an xa_alloc failure occurs the error exit path leaks
>> the allocated object mc.  Fix this by adding an error return path
>> that frees mc and rename error exit paths err3 to err4 and err2 to err3.
> 
> I propose to choose further alternatives for numbered labels.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=9c7d619be5a002ea29c172df5e3c1227c22cbb41#n485
> 
> Regards,
> Markus
> 
That's nice