linux-kernel - Re: [PATCH v5 0/4] user space client interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81cdf27e-b962-3b0b-3f78-dfd95e2cf9bc@codeaurora.org>
Date:   Wed, 2 Sep 2020 13:31:34 -0700
From:   Hemant Kumar <hemantk@...eaurora.org>
To:     gregkh@...uxfoundation.org, manivannan.sadhasivam@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        jhugo@...eaurora.org, bbhatt@...eaurora.org
Subject: Re: [PATCH v5 0/4] user space client interface driver

Hi Jeff and Mani,
On 8/5/20 11:40 PM, Hemant Kumar wrote:
> V5:
> - Removed mhi_uci_drv structure.
> - Used idr instead of creating global list of uci devices.
> - Used kref instead of local ref counting for uci device and
>    open count.
> - Removed unlikely macro.
> 
> V4:
> - Fix locking to protect proper struct members.
> - Updated documentation describing uci client driver use cases.
> - Fixed uci ref counting in mhi_uci_open for error case.
> - Addressed style related review comments.
> 
> V3: Added documentation for MHI UCI driver.
> 
> V2: Added mutex lock to prevent multiple readers to access same
> mhi buffer which can result into use after free.
> 
> Hemant Kumar (4):
>    bus: mhi: core: Add helper API to return number of free TREs
>    bus: mhi: core: Move MHI_MAX_MTU to external header file
>    docs: Add documentation for userspace client interface
>    bus: mhi: clients: Add userspace client interface driver
> 
>   Documentation/mhi/index.rst      |   1 +
>   Documentation/mhi/uci.rst        |  39 +++
>   drivers/bus/mhi/Kconfig          |   6 +
>   drivers/bus/mhi/Makefile         |   1 +
>   drivers/bus/mhi/clients/Kconfig  |  15 +
>   drivers/bus/mhi/clients/Makefile |   3 +
>   drivers/bus/mhi/clients/uci.c    | 662 +++++++++++++++++++++++++++++++++++++++
>   drivers/bus/mhi/core/internal.h  |   1 -
>   drivers/bus/mhi/core/main.c      |  12 +
>   include/linux/mhi.h              |  12 +
>   10 files changed, 751 insertions(+), 1 deletion(-)
>   create mode 100644 Documentation/mhi/uci.rst
>   create mode 100644 drivers/bus/mhi/clients/Kconfig
>   create mode 100644 drivers/bus/mhi/clients/Makefile
>   create mode 100644 drivers/bus/mhi/clients/uci.c
> 

Could you please review my changes on V5? I tried addressing Greg's 
comment and would need help getting it reviewed from other contributors 
to MHI driver as well.

Thanks,
Hemant
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project