linux-kernel - Re: [PATCH] KVM: nVMX: Add VM-Enter failed tracepoints for super early checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200902221430.GJ11695@sjchrist-ice>
Date:   Wed, 2 Sep 2020 15:14:31 -0700
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: nVMX: Add VM-Enter failed tracepoints for super
 early checks

On Tue, Sep 01, 2020 at 10:21:15AM +0200, Vitaly Kuznetsov wrote:
> Sean Christopherson <sean.j.christopherson@...el.com> writes:
> 
> > Add tracepoints for the early consistency checks in nested_vmx_run().
> > The "VMLAUNCH vs. VMRESUME" check in particular is useful to trace, as
> > there is no architectural way to check VMCS.LAUNCH_STATE, and subtle
> > bugs such as VMCLEAR on the wrong HPA can lead to confusing errors in
> > the L1 VMM.
> >
> > Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>
> > ---
> >  arch/x86/kvm/vmx/nested.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> > index 23b58c28a1c92..fb37f0972e78a 100644
> > --- a/arch/x86/kvm/vmx/nested.c
> > +++ b/arch/x86/kvm/vmx/nested.c
> > @@ -3468,11 +3468,11 @@ static int nested_vmx_run(struct kvm_vcpu *vcpu, bool launch)
> >  	if (evmptrld_status == EVMPTRLD_ERROR) {
> 
> Would it make sense to add 'CC' here too for, em, consistency? :-) #UD
> is probably easy to spot anyway..

I'd prefer not to, purely because it's a #UD and not a VM-Fail.