linux-kernel - Re: [PATCH v5 00/14] irqchip: Fix potential resource leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02e077df-7c4e-24a7-1640-5f17894bd252@loongson.cn>
Date:   Wed, 2 Sep 2020 11:59:30 +0800
From:   Tiezhu Yang <yangtiezhu@...ngson.cn>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 00/14] irqchip: Fix potential resource leaks

On 07/06/2020 03:30 PM, Marc Zyngier wrote:
> On 2020-07-06 02:19, Tiezhu Yang wrote:
>> When I test the irqchip code of Loongson, I read the related code of 
>> other
>> chips in drivers/irqchip and I find some potential resource leaks in the
>> error path, I think it is better to fix them.
>>
>> v2:
>>   - Split the first patch into a new patch series which
>>     includes small patches and add "Fixes" tag
>>   - Use "goto" label to handle error path in some patches
>>
>> v3:
>>   - Add missed variable "ret" in the patch #5 and #13
>>
>> v4:
>>   - Modify the commit message of each patch suggested by Markus Elfring
>>   - Make "irq_domain_remove(root_domain)" under CONFIG_SMP in patch #3
>>   - Add a return statement before goto label in patch #4
>>
>> v5:
>>   - Modify the commit messages and do some code cleanups
>
> Please stop replying to Markus Elfring, and give people who actually
> care a chance to review this code. Elfring will keep asking you to make
> absolutely pointless changes until you are blue in the face

Hi Marc,

Any comments?
Could you please apply this patch series?

Thanks,
Tiezhu

>
>
> Thanks,
>
>         M.