linux-kernel - Re: [PATCH v6 1/5] perf/jevents: Remove jevents.h file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Sep 2020 08:25:08 +0100
From:   John Garry <john.garry@...wei.com>
To:     kajoljain <kjain@...ux.ibm.com>, Jiri Olsa <jolsa@...hat.com>
CC:     <acme@...nel.org>, <peterz@...radead.org>, <mingo@...hat.com>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <pc@...ibm.com>, <namhyung@...nel.org>, <ak@...ux.intel.com>,
        <yao.jin@...ux.intel.com>, <linux-kernel@...r.kernel.org>,
        <linux-perf-users@...r.kernel.org>, <irogers@...gle.com>,
        <maddy@...ux.ibm.com>, <ravi.bangoria@...ux.ibm.com>
Subject: Re: [PATCH v6 1/5] perf/jevents: Remove jevents.h file

On 01/09/2020 06:56, kajoljain wrote:
>>>> +#define min(x, y) ({                \
>>>> +    typeof(x) _min1 = (x);            \
>>>> +    typeof(y) _min2 = (y);            \
>>>> +    (void)(&_min1 == &_min2);        \
>>>> +    _min1 < _min2 ? _min1 : _min2; })
>>>> +#endif
>> Wondering what is special about this definition of min that it's required? Compiled ok for me without it.
> Hi John,
>       You are right, for me also in power it compiled without any issues, but not sure if somewhere we have dependency,
> that's why I didn't remove it.

If it builds for x86, then that's main thing ;) But seriously, Arnaldo 
has lots of bots to test builds also.

BTW, I got this from your patchset:

pmu-events/jevents.c:98:29: warning: no previous prototype for 
‘get_cpu_str’ [-Wmissing-prototypes]
__attribute__((weak)) char *get_cpu_str(void)
                             ^~~~~~~~~~~
pmu-events/jevents.c:529:5: warning: no previous prototype for 
‘json_events’ [-Wmissing-prototypes]
int json_events(const char *fn,
     ^~~~~~~~~~~

But I think that you will remove this.

Finally, generated pmu-events.c looks ok for arm64, which I am 
interested in.

Thanks,
John