linux-kernel - Re: [PATCH] arm64/module: set trampoline section flags regardless of CONFIG_DYNAMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159903220030.29783.15985807326722906910.b4-ty@arm.com>
Date:   Wed,  2 Sep 2020 08:37:02 +0100
From:   Catalin Marinas <catalin.marinas@....com>
To:     Jessica Yu <jeyu@...nel.org>, linux-kernel@...r.kernel.org
Cc:     Will Deacon <will@...nel.org>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Szabolcs Nagy <szabolcs.nagy@....com>,
        linux-arm-kernel@...ts.infradead.org,
        Ard Biesheuvel <ardb@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH] arm64/module: set trampoline section flags regardless of CONFIG_DYNAMIC_FTRACE

On Tue, 1 Sep 2020 18:00:16 +0200, Jessica Yu wrote:
> In the arm64 module linker script, the section .text.ftrace_trampoline
> is specified unconditionally regardless of whether CONFIG_DYNAMIC_FTRACE
> is enabled (this is simply due to the limitation that module linker
> scripts are not preprocessed like the vmlinux one).
> 
> Normally, for .plt and .text.ftrace_trampoline, the section flags
> present in the module binary wouldn't matter since module_frob_arch_sections()
> would assign them manually anyway. However, the arm64 module loader only
> sets the section flags for .text.ftrace_trampoline when CONFIG_DYNAMIC_FTRACE=y.
> That's only become problematic recently due to a recent change in
> binutils-2.35, where the .text.ftrace_trampoline section (along with the
> .plt section) is now marked writable and executable (WAX).
> 
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64/module: set trampoline section flags regardless of CONFIG_DYNAMIC_FTRACE
      https://git.kernel.org/arm64/c/e0328feda79d

-- 
Catalin