linux-kernel - Re: [PATCH] signal: clean up codestyle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e436dd19f0e740ebb93133ae3c625af4@huawei.com>
Date:   Wed, 2 Sep 2020 01:34:59 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Christian Brauner <christian.brauner@...ntu.com>,
        Oleg Nesterov <oleg@...hat.com>
CC:     "axboe@...nel.dk" <axboe@...nel.dk>,
        "ebiederm@...ssion.com" <ebiederm@...ssion.com>,
        "madhuparnabhowmik10@...il.com" <madhuparnabhowmik10@...il.com>,
        "gustavoars@...nel.org" <gustavoars@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] signal: clean up codestyle

Christian Brauner <christian.brauner@...ntu.com> wrote:
>On Tue, Sep 01, 2020 at 06:39:05PM +0200, Oleg Nesterov wrote:
>> On 09/01, Christian Brauner wrote:
>> >
>> > On Tue, Sep 01, 2020 at 07:58:00AM -0400, Miaohe Lin wrote:
>> > > No functional change intended.
>> >
>> > Hey Miaohe,
>> >
>> > Thank you for the patch.
>> > I'm sure this is well-intended but afaict the whole file has more or 
>> > less a consistent style already where e.g. sig-1 without spaces 
>> > seems to be preferred. The same for the casts where most places use 
>> > a single space.
>> >
>> > Now, I know CodingStyle.rst is on your side at least when it comes 
>> > to the first point:
>> >
>> > Use one space around (on each side of) most binary and ternary 
>> > operators, such as any of these::
>> >
>> > 	=  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=  ?  :
>> >
>> > but then you'd need to change each place in kernel/signal.c where 
>> > that is currently not the case.
>> 
>> Or simply leave this code alone ;)
>
>I was trying to imply that by pointing out that this would be file-global change. I was likely too subtle. ;)
>
>Christian

Sorry for I did not get the imply.