linux-kernel - RE: [PATCH] clocksource: Return negative error code in h8300_8timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <bf571d3088a4419dac147729e4206574@h3c.com>
Date:   Wed, 2 Sep 2020 08:34:50 +0000
From:   Tianxianting <tian.xianting@....com>
To:     Markus Elfring <Markus.Elfring@....de>,
        "uclinux-h8-devel@...ts.sourceforge.jp" 
        <uclinux-h8-devel@...ts.sourceforge.jp>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "Daniel Lezcano" <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>
Subject: RE: [PATCH] clocksource: Return negative error code in
 h8300_8timer_init()

Hi Markus,
Thanks for your comments.
No real fix, as normally , we should return a negative code,
In function h8300_8timer_init(),  it set ' ret = -EINVAL ', ' ret = ENXIO' , it should be align with a negative code

static int __init h8300_8timer_init(struct device_node *node)
{

        ret = ENXIO;  <<<
        base = of_iomap(node, 0);
        if (!base) {
                pr_err("failed to map registers for clockevent\n");
                goto free_clk;
        }

        ret = -EINVAL;  <<<  
        irq = irq_of_parse_and_map(node, 0);
        if (!irq) {
                pr_err("failed to get irq for clockevent\n");
                goto unmap_reg;
        }

-----Original Message-----
From: Markus Elfring [mailto:Markus.Elfring@....de] 
Sent: Tuesday, September 01, 2020 10:46 PM
To: tianxianting (RD) <tian.xianting@....com>; uclinux-h8-devel@...ts.sourceforge.jp
Cc: linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org; Daniel Lezcano <daniel.lezcano@...aro.org>; Thomas Gleixner <tglx@...utronix.de>; Yoshinori Sato <ysato@...rs.sourceforge.jp>
Subject: Re: [PATCH] clocksource: Return negative error code in h8300_8timer_init()

> A negative error code should be returned

* Can an other imperative wording become helpful for the change description?

* Would you like to add the tag “Fixes” to the commit message?

Regards,
Markus