linux-kernel - Re: [PATCH] arm64: topology: Stop using MPIDR for topology information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200902105045.GB25462@bogus>
Date:   Wed, 2 Sep 2020 11:50:45 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     "Zengtao (B)" <prime.zeng@...ilicon.com>
Cc:     Valentin Schneider <valentin.schneider@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Jeremy Linton <Jeremy.Linton@....com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Morten Rasmussen <morten.rasmussen@....com>
Subject: Re: [PATCH] arm64: topology: Stop using MPIDR for topology
 information

On Wed, Sep 02, 2020 at 03:24:17AM +0000, Zengtao (B) wrote:
> Hi Valentin:
>
> > -----Original Message-----
> > From: Valentin Schneider [mailto:valentin.schneider@....com]
> > Sent: Saturday, August 29, 2020 9:00 PM
> > To: linux-kernel@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> > Cc: Catalin Marinas; Will Deacon; Sudeep Holla; Robin Murphy; Jeremy
> > Linton; Dietmar Eggemann; Morten Rasmussen; Zengtao (B)
> > Subject: [PATCH] arm64: topology: Stop using MPIDR for topology
> > information
> >
> > In the absence of ACPI or DT topology data, we fallback to haphazardly
> > decoding *something* out of MPIDR. Sadly, the contents of that register
> > are
> > mostly unusable due to the implementation leniancy and things like Aff0
> > having to be capped to 15 (despite being encoded on 8 bits).
> >
> > Consider a simple system with a single package of 32 cores, all under the
> > same LLC. We ought to be shoving them in the same core_sibling mask,
> > but
> > MPIDR is going to look like:
> >
> >   | CPU  | 0 | ... | 15 | 16 | ... | 31 |
> >   |------+---+-----+----+----+-----+----+
> >   | Aff0 | 0 | ... | 15 |  0 | ... | 15 |
> >   | Aff1 | 0 | ... |  0 |  1 | ... |  1 |
> >   | Aff2 | 0 | ... |  0 |  0 | ... |  0 |
> >
> > Which will eventually yield
> >
> >   core_sibling(0-15)  == 0-15
> >   core_sibling(16-31) == 16-31
> >
> > NUMA woes
> > =========
> >
> > If we try to play games with this and set up NUMA boundaries within those
> > groups of 16 cores via e.g. QEMU:
> >
> >   # Node0: 0-9; Node1: 10-19
> >   $ qemu-system-aarch64 <blah> \
> >     -smp 20 -numa node,cpus=0-9,nodeid=0 -numa
> > node,cpus=10-19,nodeid=1
> >
> > The scheduler's MC domain (all CPUs with same LLC) is going to be built via
> >
> >   arch_topology.c::cpu_coregroup_mask()
> >
> > In there we try to figure out a sensible mask out of the topology
> > information we have. In short, here we'll pick the smallest of NUMA or
> > core sibling mask.
> >
> >   node_mask(CPU9)    == 0-9
> >   core_sibling(CPU9) == 0-15
> >
> > MC mask for CPU9 will thus be 0-9, not a problem.
> >
> >   node_mask(CPU10)    == 10-19
> >   core_sibling(CPU10) == 0-15
> >
> > MC mask for CPU10 will thus be 10-19, not a problem.
> >
> >   node_mask(CPU16)    == 10-19
> >   core_sibling(CPU16) == 16-19
> >
> > MC mask for CPU16 will thus be 16-19... Uh oh. CPUs 16-19 are in two
> > different unique MC spans, and the scheduler has no idea what to make of
> > that. That triggers the WARN_ON() added by commit
> >
> >   ccf74128d66c ("sched/topology: Assert non-NUMA topology masks
> > don't (partially) overlap")
> >
> > Fixing MPIDR-derived topology
> > =============================
> >
> > We could try to come up with some cleverer scheme to figure out which of
> > the available masks to pick, but really if one of those masks resulted from
> > MPIDR then it should be discarded because it's bound to be bogus.
> >
> > I was hoping to give MPIDR a chance for SMT, to figure out which threads
> > are
> > in the same core using Aff1-3 as core ID, but Sudeep and Robin pointed out
> > to me that there are systems out there where *all* cores have non-zero
> > values in their higher affinity fields (e.g. RK3288 has "5" in all of its
> > cores' MPIDR.Aff1), which would expose a bogus core ID to userspace.
> >
> > Stop using MPIDR for topology information. When no other source of
> > topology
> > information is available, mark each CPU as its own core and its NUMA
> > node
> > as its LLC domain.
>
> I agree with your idea to remove the topology functionality of MPIDR ,
> but I think we need also consider ARM32 and GIC.
>

This is changing only arm64 for now. For fun, looked at some arm32 DTS:
arch/arm/boot/dts/aspeed-g6.dtsi
arch/arm/boot/dts/bcm2836.dtsi
arch/arm/boot/dts/exynos4210.dtsi
arch/arm/boot/dts/exynos4412.dtsi
arch/arm/boot/dts/highbank.dts
arch/arm/boot/dts/imx7ulp.dtsi
arch/arm/boot/dts/ls1021a.dtsi
arch/arm/boot/dts/meson6.dtsi
arch/arm/boot/dts/meson8.dtsi
arch/arm/boot/dts/meson8b.dtsi
arch/arm/boot/dts/milbeaut-m10v.dtsi
arch/arm/boot/dts/rk3036.dtsi
arch/arm/boot/dts/rk322x.dtsi
arch/arm/boot/dts/rk3288.dtsi
arch/arm/boot/dts/rtd1195.dtsi
arch/arm/boot/dts/rv1108.dtsi
arch/arm/boot/dts/ste-dbx5x0.dtsi

These have random non-zero values in Aff1 or Aff2. I may have generated
some false positives with simple search.

--
Regards,
Sudeep