linux-kernel - Re: [PATCH] char: virtio: Select VIRTIO from VIRTIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200902121652.GA4173@merlin.infradead.org>
Date:   Wed, 2 Sep 2020 08:16:52 -0400
From:   Amit Shah <amit@...radead.org>
To:     Michal Suchanek <msuchanek@...e.de>
Cc:     Amit Shah <amit@...nel.org>,
        virtualization@...ts.linux-foundation.org,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: virtio: Select VIRTIO from VIRTIO_CONSOLE.

On Mon, Aug 31, 2020 at 06:58:50PM +0200, Michal Suchanek wrote:
> Make it possible to have virtio console built-in when
> other virtio drivers are modular.
> 
> Signed-off-by: Michal Suchanek <msuchanek@...e.de>

Reviewed-by: Amit Shah <amit@...nel.org>

> ---
>  drivers/char/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 3a144c000a38..9bd9917ca9af 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -93,8 +93,9 @@ config PPDEV
>  
>  config VIRTIO_CONSOLE
>  	tristate "Virtio console"
> -	depends on VIRTIO && TTY
> +	depends on TTY
>  	select HVC_DRIVER
> +	select VIRTIO
>  	help
>  	  Virtio console for use with hypervisors.
>  
> -- 
> 2.28.0
>