linux-kernel - Re: [PATCH net-next 1/3] dt-bindings: net: Document Broadcom SF2 switch clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200902124335.GB3071395@lunn.ch>
Date:   Wed, 2 Sep 2020 14:43:35 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: Document Broadcom SF2
 switch clocks

On Tue, Sep 01, 2020 at 03:59:11PM -0700, Florian Fainelli wrote:
> Describe the two possible clocks feeding into the Broadcom SF2
> integrated Ethernet switch. BCM7445 systems have two clocks, one for the
> main switch core clock, and another for controlling the switch clock
> divider whereas BCM7278 systems only have the first kind.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  .../devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt   | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt b/Documentation/devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt
> index 88b57b0ca1f4..97ca62b0e14d 100644
> --- a/Documentation/devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt
> +++ b/Documentation/devicetree/bindings/net/brcm,bcm7445-switch-v4.0.txt
> @@ -50,6 +50,13 @@ Optional properties:
>  - reset-names: If the "reset" property is specified, this property should have
>    the value "switch" to denote the switch reset line.
>  
> +- clocks: when provided, the first phandle is to the switch's main clock and
> +  is valid for both BCM7445 and BCM7278. The second phandle is only applicable
> +  to BCM7445 and is to support dividing the switch core clock.
> +
> +- clock-names: when provided, the first phandle must be "sw_switch", and the
> +  second must be named "sw_switch_mdiv".

Hi Florian

Since you look clocks up by name, i don't think the order matters.

Otherwise:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew