lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Sep 2020 08:53:49 -0400 From: Pavel Tatashin <pasha.tatashin@...een.com> To: Michal Hocko <mhocko@...e.com> Cc: Vlastimil Babka <vbabka@...e.cz>, Roman Gushchin <guro@...com>, Bharata B Rao <bharata@...ux.ibm.com>, "linux-mm@...ck.org" <linux-mm@...ck.org>, Andrew Morton <akpm@...ux-foundation.org>, Johannes Weiner <hannes@...xchg.org>, Shakeel Butt <shakeelb@...gle.com>, Vladimir Davydov <vdavydov.dev@...il.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Kernel Team <Kernel-team@...com>, Yafang Shao <laoar.shao@...il.com>, stable <stable@...r.kernel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Sasha Levin <sashal@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, David Hildenbrand <david@...hat.com> Subject: Re: [PATCH v2 00/28] The new cgroup slab memory controller On Wed, Sep 2, 2020 at 7:32 AM Michal Hocko <mhocko@...e.com> wrote: > > On Wed 02-09-20 11:53:00, Vlastimil Babka wrote: > > >> > > Thread #2: ccs killer kthread > > >> > > css_killed_work_fn > > >> > > cgroup_mutex <- Grab this Mutex > > >> > > mem_cgroup_css_offline > > >> > > memcg_offline_kmem.part > > >> > > memcg_deactivate_kmem_caches > > >> > > get_online_mems > > >> > > mem_hotplug_lock <- waits for Thread#1 to get read access > > And one more thing. THis has been brought up several times already. > Maybe I have forgoten but why do we take hotplug locks in this path in > the first place? Memory hotplug notifier takes slab_mutex so this > shouldn't be really needed. Good point, it seems this lock can be completely removed from memcg_deactivate_kmem_caches Pasha > -- > Michal Hocko > SUSE Labs
Powered by blists - more mailing lists