linux-kernel - Re: [PATCH] staging: gdm724x: gdm_tty: replaced macro with a function v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200902135832.GZ8299@kadam>
Date:   Wed, 2 Sep 2020 16:58:32 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Antoni Przybylik <antoni.przybylik@...pl>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gdm724x: gdm_tty: replaced macro with a
 function v2

On Wed, Sep 02, 2020 at 03:25:59PM +0200, Antoni Przybylik wrote:
> This approach is more elegant and prevents some problems related to
> macros such as operator precedence in expanded expression.
> -------------------------------------------------------------------
> Changed return type to bool and removed inline sepcifier.
> 
> Signed-off-by: Antoni Przybylik <antoni.przybylik@...pl>
> ---
  ^^^
See this line.

No that doesn't work at all.  Try applying your patch and reviewing the
git log.  Look the the email archive to see how to send a v2 patch.

1) subject says [PATCH v2]
2) comments under the --- line

>  drivers/staging/gdm724x/gdm_tty.c | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 

regards,
dan carpenter