linux-kernel - Re: [GIT PULL] perf tools fixes for v5.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wifL-04oOF3RAbX9Odyfgz4zc4dE=pq-QL+2C-aTxUmqw@mail.gmail.com>
Date:   Tue, 1 Sep 2020 19:43:33 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-perf-users@...r.kernel.org, Al Grant <al.grant@....com>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        David Ahern <dsahern@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Leo Yan <leo.yan@...aro.org>,
        Like Xu <like.xu@...ux.intel.com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Sumanth Korikkar <sumanthk@...ux.ibm.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Wei Li <liwei391@...wei.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [GIT PULL] perf tools fixes for v5.9

On Tue, Sep 1, 2020 at 3:42 PM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> - The SNOOPX and REMOTE offsets in the data_src bitmask in perf records were
>   were both 37, SNOOPX is 38, fix it.

The kernel uapi side thinks it's 37. What's up?

  $ git grep PERF_MEM_SNOOPX_SHIFT

results in

  include/uapi/linux/perf_event.h:#define PERF_MEM_SNOOPX_SHIFT   37
  tools/include/uapi/linux/perf_event.h:#define PERF_MEM_SNOOPX_SHIFT     38

Hmm?

                   Linus