linux-kernel - Re: [PATCH 1/2] iommu: amd: Restore IRTE.RemapEn bit after programming IRTE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f38b77db-fbb2-bcab-56ef-9d23a368533b@oracle.com>
Date:   Wed, 2 Sep 2020 16:26:36 +0100
From:   Joao Martins <joao.m.martins@...cle.com>
To:     Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Cc:     linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org,
        joro@...tes.org, sean.m.osborne@...cle.com,
        james.puthukattukaran@...cle.com, boris.ostrovsky@...cle.com,
        jon.grimm@....com
Subject: Re: [PATCH 1/2] iommu: amd: Restore IRTE.RemapEn bit after
 programming IRTE

On 9/2/20 5:51 AM, Suravee Suthikulpanit wrote:
> Currently, the RemapEn (valid) bit is accidentally cleared when
> programming IRTE w/ guestMode=0. It should be restored to
> the prior state.
> 
Probably requires:

 Fixes: b9fc6b56f478 ("iommu/amd: Implements irq_set_vcpu_affinity() hook to setup vapic
mode for pass-through devices")

?

> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>

FWIW,

 Reviewed-by: Joao Martins <joao.m.martins@...cle.com>