linux-kernel - Re: [PATCH] fsi: Fix an IS_ERR() vs NULL check in occ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Sep 2020 00:30:09 +0000
From:   Joel Stanley <joel@....id.au>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     Jeremy Kerr <jk@...abs.org>, Eddie James <eajames@...ux.ibm.com>,
        Alistair Popple <alistair@...ple.id.au>,
        linux-fsi@...ts.ozlabs.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fsi: Fix an IS_ERR() vs NULL check in occ_probe()

On Tue, 1 Sep 2020 at 12:01, Jing Xiangfeng <jingxiangfeng@...wei.com> wrote:
>
> The platform_device_register_full() function returns error pointers,
> it never returns NULL.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>

Thanks for the patch. I already have this change queued up for 5.10.

> ---
>  drivers/fsi/fsi-occ.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c
> index 7da9c81759ac..9eeb856c8905 100644
> --- a/drivers/fsi/fsi-occ.c
> +++ b/drivers/fsi/fsi-occ.c
> @@ -555,7 +555,7 @@ static int occ_probe(struct platform_device *pdev)
>
>         hwmon_dev_info.id = occ->idx;
>         hwmon_dev = platform_device_register_full(&hwmon_dev_info);
> -       if (!hwmon_dev)
> +       if (IS_ERR(hwmon_dev))
>                 dev_warn(dev, "failed to create hwmon device\n");
>
>         return 0;
> --
> 2.17.1
>