Message-ID: <CAK7LNATvXzVHzZHRCPOeS+qbNxDV5G=ihpXCZOmbRx-Six=zyQ@mail.gmail.com>
Date:   Thu, 3 Sep 2020 01:41:39 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Changbin Du <changbin.du@...il.com>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Nathan Royce <nroycea+kernel@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, X86 ML <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: localmodconfig - "intel_rapl_perf config not found!!"

On Thu, Aug 27, 2020 at 1:30 AM Changbin Du <changbin.du@...il.com> wrote:
>
> On Tue, Aug 25, 2020 at 02:34:34PM -0700, Randy Dunlap wrote:
> > On 8/25/20 2:12 PM, Randy Dunlap wrote:
> > >> On Tue, Aug 25, 2020 at 2:13 PM Randy Dunlap <rdunlap@...radead.org> wrote:
> > >>>
> > >>> so intel_rapl_perf is listed in your lsmod.cfg file:
> > >>> intel_rapl_perf        16384  2
> > >>>
> > >>> You say Linux 5.8.3.  I'm guessing that your "make localmodconfig" tree
> > >>> is Linux 5.8.3 (?).  What kernel version are you running?
> > >>> I think that it's older, and some file/module names have changed since then.
> > >
> > > On 8/25/20 1:34 PM, Nathan Royce wrote:
> > >> Correct. I'm building for 5.8.3 and I'm currently on 5.7.4 (1 month
> > >> doesn't seem particularly old).
> > >
> > > Yes, things can change quickly.
> > >
> > >
> > > I don't see any support in streamline_config.pl for Kconfig symbols
> > > and/or modules whose names have changed.  Trying to do something
> > > like that would be a never-ending job (a la job security).
> > >
> > > At least it gave you a warning that it couldn't find a Kconfig symbol
> > > for that module.
> > >
> > >
> > > From your original email:
> > > | I'm going to assume it has something to do with the naming and it's
> > > | supposed to be associated with "Intel/AMD rapl performance events
> > > | (CONFIG_PERF_EVENTS_INTEL_RAPL)" which I already have set to 'Y'.
> > >
> > > Yes, commit fd3ae1e1587d64ef8cc8e361903d33625458073e changed the module name
> > > since it now supports both Intel and AMD.
> > >
> > >
> > > | Right below that, I also get 'Use of uninitialized value
> > > | $ENV{"LMC_KEEP"} in split at ./scripts/kconfig/streamline_config.pl
> > > | line 596.', but again that is the sort of thing that may warrant a new
> > > | email specific to localmodconfig author(s). But again maybe not
> > > | because I take it more as a warning given I don't make use of
> > > | LMC_KEEP.
> > >
> > >
> > > @Changbin: can you fix this little bug in streamline_config.pl, please? ^^^^^
> This was tested before. Is this a perl version issue?
>
> changbin@...tr:~$ cat a.pl
> my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> print("@preserved_kconfigs")
> changbin@...tr:~$ perl a.pl
> changbin@...tr:~$ perl -v
> This is perl 5, version 26, subversion 1 (v5.26.1) built for x86_64-linux-gnu-thread-multi
> (with 67 registered patches, see perl -V for more detail)
>
> Copyright 1987-2017, Larry Wall
>
> Perl may be copied only under the terms of either the Artistic License or the
> GNU General Public License, which may be found in the Perl 5 source kit.
>
> Complete documentation for Perl, including FAQ lists, should be found on
> this system using "man perl" or "perldoc perl".  If you have access to the
> Internet, point your browser at http://www.perl.org/, the Perl Home Page.
> >
> > Changing email address for Changbin.
> > Plus I made the quick patch for streamline_config.pl (below)
> > although I haven't tested it.
> >
> > ---
> > From: Randy Dunlap <rdunlap@...radead.org>
> >
> > A user reported:
> > 'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
> >  ./scripts/kconfig/streamline_config.pl line 596.'
> >
> > so first check that $ENV{LMC_KEEP} is defined before trying
> > to use it.
> >
> > Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs")
> > Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> > Cc: Changbin Du <changbin.du@...il.com>
> > Cc: Steven Rostedt (VMware) <rostedt@...dmis.org>
> > Cc: Masahiro Yamada <masahiroy@...nel.org>
> > ---
> >  scripts/kconfig/streamline_config.pl |    5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > --- linux-next-20200825.orig/scripts/kconfig/streamline_config.pl
> > +++ linux-next-20200825/scripts/kconfig/streamline_config.pl
> > @@ -593,7 +593,10 @@ while ($repeat) {
> >  }
> >
> >  my %setconfigs;
> > -my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> > +my @preserved_kconfigs;
> > +if (defined($ENV{'LMC_KEEP'})) {
> > +     @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> > +}
> >
> >  sub in_preserved_kconfigs {
> >      my $kconfig = $config2kfile{$_[0]};
> >
>
> --
> Cheers,
> Changbin Du



Hmm, I think I did not see this warning before,
but I am not sure...
Now I see this warning too, maybe perl version-dependent.


-- 
Best Regards
Masahiro Yamada

Powered by blists - more mailing lists