lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Sep 2020 13:26:58 -0500 From: Kim Phillips <kim.phillips@....com> To: Ian Rogers <irogers@...gle.com> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>, Mark Rutland <mark.rutland@....com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>, Namhyung Kim <namhyung@...nel.org>, Vijay Thakkar <vijaythakkar@...com>, Andi Kleen <ak@...ux.intel.com>, John Garry <john.garry@...wei.com>, Kan Liang <kan.liang@...ux.intel.com>, Yunfeng Ye <yeyunfeng@...wei.com>, Jin Yao <yao.jin@...ux.intel.com>, Martin Liška <mliska@...e.cz>, Borislav Petkov <bp@...e.de>, Jon Grimm <jon.grimm@....com>, Martin Jambor <mjambor@...e.cz>, Michael Petlan <mpetlan@...hat.com>, William Cohen <wcohen@...hat.com>, Stephane Eranian <eranian@...gle.com>, linux-perf-users <linux-perf-users@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 3/4] perf vendor events amd: Add recommended events On 9/3/20 1:19 AM, Ian Rogers wrote: > On Tue, Sep 1, 2020 at 3:10 PM Kim Phillips <kim.phillips@....com> wrote: >> The nps1_die_to_dram event may need perf stat's --metric-no-group >> switch if the number of available data fabric counters is less >> than the number it uses (8). > > These are really excellent additions! Does: > "MetricConstraint": "NO_NMI_WATCHDOG" > solve the grouping issue? Perhaps the MetricConstraint needs to be > named more generically to cover this case as it seems sub-optimal to > require the use of --metric-no-group. That metric uses data fabric (DFPMC/amd_df) events, not Core PMC events, which the watchdog uses, so NO_NMI_WATCHDOG wouldn't have an effect. The event is defined as an approximation anyway. I'll have to get back to you on the other items. Thanks for your review! Kim
Powered by blists - more mailing lists