linux-kernel - Re: [PATCH RESEND] smsc9420: switch from 'pci_' to 'dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200903.165432.788429825388438913.davem@davemloft.net>
Date:   Thu, 03 Sep 2020 16:54:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     kuba@...nel.org, steve.glendinning@...well.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH RESEND] smsc9420: switch from 'pci_' to 'dma_' API

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Thu,  3 Sep 2020 22:10:55 +0200

> The wrappers in include/linux/pci-dma-compat.h should go away.
> 
> The patch has been generated with the coccinelle script below and has been
> hand modified to replace GFP_ with a correct flag.
> It has been compile tested.
> 
> When memory is allocated in 'smsc9420_probe()', GFP_KERNEL can be used
> because it is a probe function and no lock is acquired.
> 
> While at it, rewrite the size passed to 'dma_alloc_coherent()' the same way
> as the one passed to 'dma_free_coherent()'. This form is less verbose:
>    sizeof(struct smsc9420_dma_desc) * RX_RING_SIZE +
>    sizeof(struct smsc9420_dma_desc) * TX_RING_SIZE,
> vs
>    sizeof(struct smsc9420_dma_desc) * (RX_RING_SIZE + TX_RING_SIZE)
 ...
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied.