linux-kernel - Re: [PATCH] mmc: s3cmci: Drop unused variables in dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Sep 2020 10:10:08 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Ben Dooks <ben-linux@...ff.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: s3cmci: Drop unused variables in dbg_dumpregs

On Thu, 3 Sep 2020 at 07:43, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> The 'imask' and 'bsize' are not used in dbg_dumpregs:
>
>   drivers/mmc/host/s3cmci.c:149:36: warning: variable 'imask' set but not used [-Wunused-but-set-variable]
>   drivers/mmc/host/s3cmci.c:148:63: warning: variable 'bsize' set but not used [-Wunused-but-set-variable]
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/s3cmci.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c
> index ac94f926624d..40329aeacfdf 100644
> --- a/drivers/mmc/host/s3cmci.c
> +++ b/drivers/mmc/host/s3cmci.c
> @@ -145,8 +145,8 @@ static void s3cmci_reset(struct s3cmci_host *host);
>
>  static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
>  {
> -       u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer, bsize;
> -       u32 datcon, datcnt, datsta, fsta, imask;
> +       u32 con, pre, cmdarg, cmdcon, cmdsta, r0, r1, r2, r3, timer;
> +       u32 datcon, datcnt, datsta, fsta;
>
>         con     = readl(host->base + S3C2410_SDICON);
>         pre     = readl(host->base + S3C2410_SDIPRE);
> @@ -158,12 +158,10 @@ static void dbg_dumpregs(struct s3cmci_host *host, char *prefix)
>         r2      = readl(host->base + S3C2410_SDIRSP2);
>         r3      = readl(host->base + S3C2410_SDIRSP3);
>         timer   = readl(host->base + S3C2410_SDITIMER);
> -       bsize   = readl(host->base + S3C2410_SDIBSIZE);
>         datcon  = readl(host->base + S3C2410_SDIDCON);
>         datcnt  = readl(host->base + S3C2410_SDIDCNT);
>         datsta  = readl(host->base + S3C2410_SDIDSTA);
>         fsta    = readl(host->base + S3C2410_SDIFSTA);
> -       imask   = readl(host->base + host->sdiimsk);
>
>         dbg(host, dbg_debug, "%s  CON:[%08x]  PRE:[%08x]  TMR:[%08x]\n",
>                                 prefix, con, pre, timer);
> --
> 2.17.1
>