linux-kernel - Re: [PATCH RESEND v1 05/11] perf mem: Support AUX trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200903090724.GB1583@leoy-ThinkPad-X240s>
Date:   Thu, 3 Sep 2020 17:07:24 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     James Clark <james.clark@....com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>,
        Ian Rogers <irogers@...gle.com>,
        Kemeng Shi <shikemeng@...wei.com>,
        Wei Li <liwei391@...wei.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Al Grant <Al.Grant@....com>, linux-kernel@...r.kernel.org,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Mike Leach <mike.leach@...aro.org>, nd <nd@....com>
Subject: Re: [PATCH RESEND v1 05/11] perf mem: Support AUX trace

Hi James,

On Tue, Sep 01, 2020 at 04:52:54PM +0100, James Clark wrote:
> Hi Leo,
> 
> >  
> > +static int process_attr(struct perf_tool *tool __maybe_unused,
> > +			union perf_event *event,
> > +			struct evlist **pevlist)
> > +{
> > +	int err;
> > +
> > +	err = perf_event__process_attr(tool, event, pevlist);
> > +	if (err)
> > +		return err;
> > +
> > +	return 0;
> > +}
> > +
> >  int cmd_mem(int argc, const char **argv)
> >  {
> >  	struct stat st;
> > @@ -405,8 +430,12 @@ int cmd_mem(int argc, const char **argv)
> >  			.comm		= perf_event__process_comm,
> >  			.lost		= perf_event__process_lost,
> >  			.fork		= perf_event__process_fork,
> > +			.attr		= process_attr,
> >  			.build_id	= perf_event__process_build_id,
> 
> I don't understand the __maybe_unused here. And also isn't this equivalent
> to this without the new function:
> 
>   @@ -405,8 +430,12 @@ int cmd_mem(int argc, const char **argv)
>    			.comm		= perf_event__process_comm,
>    			.lost		= perf_event__process_lost,
>    			.fork		= perf_event__process_fork,
>   +			.attr		= perf_event__process_attr,
>    			.build_id	= perf_event__process_build_id,

Thanks for pointing out this, will fix this with your suggestion.

Thanks,
Leo