linux-kernel - Re: [PATCH] irqchip/gic-v3: change gic_data into gic_v3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Sep 2020 18:05:16 +0800
From:   zc <zoucao@...ux.alibaba.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        tglx@...utronix.de, jason@...edaemon.net
Subject: Re: [PATCH] irqchip/gic-v3: change gic_data into gic_v3_data


   thank for you reply.


    of course it won't,   i just think it is better to splite the global 
data between irq-gic and irq-gic-v3.

I wrote some hook module for gic,  kallsyms_lookup_name can't support 
for mutlipte symbol,

i need to call kallsyms scan to get the addr.


   If you think it isn't necessary, well for me.


Regards,

zou cao

在 2020/9/3 下午5:55, Marc Zyngier 写道:
> On 2020-09-03 10:08, Zou Cao wrote:
>> There are multiple gic_data symbol between irq_gic.c and irq_gic_v3.c,
>> we can see the same symbol name:
>>
>>     cat /proc/kallsyms | grep gic_data
>> ------>
>>     ffff80001138f1d0 d gic_data
>>     ffff80001138f940 d gic_data
>>
>> Normally CONFIG_ARM_GIC and CONFIG_ARM_GIC_V3 are all enabled, move
>> the gic_data symbol into different name, it will be friend for
>> kallsyms_lookup_name to get addr easily.
>>
>> Signed-off-by: Zou Cao <zoucao@...ux.alibaba.com>
>
> I'm sorry, but this kind of change is not acceptable.
>
> It is pure churn, for zero benefit. As an example, give the following
> script a go:
>
> awk '{ print $3 }' /proc/kallsyms | sort | uniq -c| awk '$1 > 1 
> {print}'| sort -n
>
> Are you going to repaint all these symbols?
>
>         M.