| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <6cf65d7c-adff-5a56-f836-0affd68fbfe2@rock-chips.com>
Date: Thu, 3 Sep 2020 18:02:12 +0800
From: Kever Yang <kever.yang@...k-chips.com>
To: Elaine Zhang <zhangqing@...k-chips.com>, heiko@...ech.de
Cc: mturquette@...libre.com, sboyd@...nel.org,
linux-clk@...r.kernel.org, linux-rockchip@...ts.infradead.org,
linux-kernel@...r.kernel.org, xxx@...k-chips.com,
xf@...k-chips.com, huangtao@...k-chips.com
Subject: Re: [PATCH v2 1/6] clk: rockchip: Use clk_hw_register_composite
instead of clk_register_composite calls
Hi Elaine,
On 2020/9/3 下午2:31, Elaine Zhang wrote:
> clk_hw_register_composite it's already exported.
> Preparation for compilation of rK common clock drivers into modules.
>
> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
> ---
> drivers/clk/rockchip/clk-half-divider.c | 18 ++++----
> drivers/clk/rockchip/clk.c | 58 ++++++++++++-------------
> 2 files changed, 38 insertions(+), 38 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-half-divider.c b/drivers/clk/rockchip/clk-half-divider.c
> index b333fc28c94b..e97fd3dfbae7 100644
> --- a/drivers/clk/rockchip/clk-half-divider.c
> +++ b/drivers/clk/rockchip/clk-half-divider.c
> @@ -166,7 +166,7 @@ struct clk *rockchip_clk_register_halfdiv(const char *name,
> unsigned long flags,
> spinlock_t *lock)
> {
> - struct clk *clk;
> + struct clk_hw *hw;
> struct clk_mux *mux = NULL;
> struct clk_gate *gate = NULL;
> struct clk_divider *div = NULL;
> @@ -212,16 +212,18 @@ struct clk *rockchip_clk_register_halfdiv(const char *name,
> div_ops = &clk_half_divider_ops;
> }
>
> - clk = clk_register_composite(NULL, name, parent_names, num_parents,
> - mux ? &mux->hw : NULL, mux_ops,
> - div ? &div->hw : NULL, div_ops,
> - gate ? &gate->hw : NULL, gate_ops,
> - flags);
> + hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,
> + mux ? &mux->hw : NULL, mux_ops,
> + div ? &div->hw : NULL, div_ops,
> + gate ? &gate->hw : NULL, gate_ops,
> + flags);
> + if (IS_ERR(hw))
> + goto err_div;
>
> - return clk;
> + return hw->clk;
> err_div:
> kfree(gate);
> err_gate:
> kfree(mux);
> - return ERR_PTR(-ENOMEM);
> + return ERR_CAST(hw);
> }
> diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
> index 546e810c3560..b51f320e5733 100644
> --- a/drivers/clk/rockchip/clk.c
> +++ b/drivers/clk/rockchip/clk.c
> @@ -43,7 +43,7 @@ static struct clk *rockchip_clk_register_branch(const char *name,
> u8 gate_shift, u8 gate_flags, unsigned long flags,
> spinlock_t *lock)
> {
> - struct clk *clk;
> + struct clk_hw *hw;
> struct clk_mux *mux = NULL;
> struct clk_gate *gate = NULL;
> struct clk_divider *div = NULL;
> @@ -100,25 +100,22 @@ static struct clk *rockchip_clk_register_branch(const char *name,
> : &clk_divider_ops;
> }
>
> - clk = clk_register_composite(NULL, name, parent_names, num_parents,
> - mux ? &mux->hw : NULL, mux_ops,
> - div ? &div->hw : NULL, div_ops,
> - gate ? &gate->hw : NULL, gate_ops,
> - flags);
> -
> - if (IS_ERR(clk)) {
> - ret = PTR_ERR(clk);
> + hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,
> + mux ? &mux->hw : NULL, mux_ops,
> + div ? &div->hw : NULL, div_ops,
> + gate ? &gate->hw : NULL, gate_ops,
> + flags);
> + if (IS_ERR(hw))
> goto err_composite;
> - }
>
> - return clk;
> + return hw->clk;
> err_composite:
> kfree(div);
> err_div:
> kfree(gate);
> err_gate:
> kfree(mux);
> - return ERR_PTR(ret);
> + return ERR_CAST(hw);
> }
>
> struct rockchip_clk_frac {
> @@ -214,8 +211,8 @@ static struct clk *rockchip_clk_register_frac_branch(
> unsigned long flags, struct rockchip_clk_branch *child,
> spinlock_t *lock)
> {
> + struct clk_hw *hw;
> struct rockchip_clk_frac *frac;
> - struct clk *clk;
> struct clk_gate *gate = NULL;
> struct clk_fractional_divider *div = NULL;
> const struct clk_ops *div_ops = NULL, *gate_ops = NULL;
> @@ -255,14 +252,14 @@ static struct clk *rockchip_clk_register_frac_branch(
> div->approximation = rockchip_fractional_approximation;
> div_ops = &clk_fractional_divider_ops;
>
> - clk = clk_register_composite(NULL, name, parent_names, num_parents,
> - NULL, NULL,
> - &div->hw, div_ops,
> - gate ? &gate->hw : NULL, gate_ops,
> - flags | CLK_SET_RATE_UNGATE);
> - if (IS_ERR(clk)) {
> + hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,
> + NULL, NULL,
> + &div->hw, div_ops,
> + gate ? &gate->hw : NULL, gate_ops,
> + flags | CLK_SET_RATE_UNGATE);
> + if (IS_ERR(hw)) {
> kfree(frac);
> - return clk;
> + return ERR_CAST(hw);
> }
>
> if (child) {
> @@ -292,7 +289,7 @@ static struct clk *rockchip_clk_register_frac_branch(
> mux_clk = clk_register(NULL, &frac_mux->hw);
> if (IS_ERR(mux_clk)) {
> kfree(frac);
> - return clk;
> + return mux_clk;
> }
>
> rockchip_clk_add_lookup(ctx, mux_clk, child->id);
> @@ -301,7 +298,7 @@ static struct clk *rockchip_clk_register_frac_branch(
> if (frac->mux_frac_idx >= 0) {
> pr_debug("%s: found fractional parent in mux at pos %d\n",
> __func__, frac->mux_frac_idx);
> - ret = clk_notifier_register(clk, &frac->clk_nb);
> + ret = clk_notifier_register(hw->clk, &frac->clk_nb);
> if (ret)
> pr_err("%s: failed to register clock notifier for %s\n",
> __func__, name);
> @@ -311,7 +308,7 @@ static struct clk *rockchip_clk_register_frac_branch(
> }
> }
>
> - return clk;
> + return hw->clk;
> }
>
> static struct clk *rockchip_clk_register_factor_branch(const char *name,
> @@ -320,7 +317,7 @@ static struct clk *rockchip_clk_register_factor_branch(const char *name,
> int gate_offset, u8 gate_shift, u8 gate_flags,
> unsigned long flags, spinlock_t *lock)
> {
> - struct clk *clk;
> + struct clk_hw *hw;
> struct clk_gate *gate = NULL;
> struct clk_fixed_factor *fix = NULL;
>
> @@ -349,16 +346,17 @@ static struct clk *rockchip_clk_register_factor_branch(const char *name,
> fix->mult = mult;
> fix->div = div;
>
> - clk = clk_register_composite(NULL, name, parent_names, num_parents,
> - NULL, NULL,
> - &fix->hw, &clk_fixed_factor_ops,
> - &gate->hw, &clk_gate_ops, flags);
> - if (IS_ERR(clk)) {
> + hw = clk_hw_register_composite(NULL, name, parent_names, num_parents,
> + NULL, NULL,
> + &fix->hw, &clk_fixed_factor_ops,
> + &gate->hw, &clk_gate_ops, flags);
> + if (IS_ERR(hw)) {
> kfree(fix);
> kfree(gate);
> + return ERR_CAST(hw);
> }
>
> - return clk;
> + return hw->clk;
> }
>
> struct rockchip_clk_provider * __init rockchip_clk_init(struct device_node *np,
This looks good to me, so
Reviewed-by: Kever Yang <kever.yang@...k-chips.com>
Thanks,
- Kever
Powered by blists - more mailing lists