linux-kernel - Re: [PATCH] KVM: Check the allocation of pv cpu mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cca7f343-6b0f-2717-a24b-a66b307f8888@gmail.com>
Date:   Thu, 3 Sep 2020 09:31:38 +0800
From:   Haiwei Li <lihaiwei.kernel@...il.com>
To:     kernel test robot <lkp@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        "hpa@...or.com" <hpa@...or.com>, "bp@...en8.de" <bp@...en8.de>,
        "mingo@...hat.com" <mingo@...hat.com>, tglx@...utronix.de,
        joro@...tes.org, jmattson@...gle.com,
        "wanpengli@...cent.com" <wanpengli@...cent.com>
Subject: Re: [PATCH] KVM: Check the allocation of pv cpu mask



On 20/9/2 01:35, kernel test robot wrote:
> Hi Haiwei,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on kvm/linux-next]
> [also build test ERROR on linus/master v5.9-rc3 next-20200828]
> [cannot apply to linux/master vhost/linux-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Haiwei-Li/KVM-Check-the-allocation-of-pv-cpu-mask/20200901-195412
> base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
> config: x86_64-randconfig-a011-20200901 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c10e63677f5d20f18010f8f68c631ddc97546f7d)
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # install x86_64 cross compiling tool for clang build
>          # apt-get install binutils-x86-64-linux-gnu
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> arch/x86/kernel/kvm.c:801:35: error: use of undeclared identifier 'kvm_send_ipi_mask_allbutself'
>             apic->send_IPI_mask_allbutself = kvm_send_ipi_mask_allbutself;
>                                              ^
>     1 error generated.

THX, i will fix and resend.

> 
> # https://github.com/0day-ci/linux/commit/13dd13ab0aefbb5c31bd8681831e6a11ac381509
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Haiwei-Li/KVM-Check-the-allocation-of-pv-cpu-mask/20200901-195412
> git checkout 13dd13ab0aefbb5c31bd8681831e6a11ac381509
> vim +/kvm_send_ipi_mask_allbutself +801 arch/x86/kernel/kvm.c
> 
>     791	
>     792		if (alloc)
>     793			for_each_possible_cpu(cpu) {
>     794				if (!zalloc_cpumask_var_node(
>     795					per_cpu_ptr(&__pv_cpu_mask, cpu),
>     796					GFP_KERNEL, cpu_to_node(cpu))) {
>     797					goto zalloc_cpumask_fail;
>     798				}
>     799			}
>     800	
>   > 801		apic->send_IPI_mask_allbutself = kvm_send_ipi_mask_allbutself;
>     802		pv_ops.mmu.flush_tlb_others = kvm_flush_tlb_others;
>     803		return 0;
>     804	
>     805	zalloc_cpumask_fail:
>     806		kvm_free_pv_cpu_mask();
>     807		return -ENOMEM;
>     808	}
>     809	arch_initcall(kvm_alloc_cpumask);
>     810	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>