linux-kernel - Re: [PATCH v2] use cpu_to_le{16,32} instead of __constant_cpu_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 02 Sep 2020 18:58:59 -0700
From:   Joe Perches <joe@...ches.com>
To:     Rene Rebe <rene@...ctcode.com>, linux-kernel@...r.kernel.org
Cc:     Arnd Bergmann <arnd@...db.de>, himanshu.madhani@...cle.com
Subject: Re: [PATCH v2] use cpu_to_le{16,32} instead of __constant_cpu_to_*

On Wed, 2020-09-02 at 23:29 +0200, Rene Rebe wrote:
> As per recommendation, convert a few remaining __constant_cpu_to_le{16,32}
> instances in the qla2xxx, qla4xxx and cifs to just cpu_to_le{16,32}.
[]
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
[]
> @@ -3583,7 +3583,7 @@ static int __qlt_send_term_imm_notif(struct scsi_qla_host *vha,
>  
>         /* terminate */
>         nack->u.isp24.flags |=
> -               __constant_cpu_to_le16(NOTIFY_ACK_FLAGS_TERMINATE);
> +               cpu_to_le16(NOTIFY_ACK_FLAGS_TERMINATE);

trivia: this now fits on a single line.