linux-kernel - Re: [PATCH V2 4/8] arm64: dts: ti: k3-am65*: Use generic clock for syscon clock names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8bc1cd8-a220-7cdf-19a7-ce95429dc509@ti.com>
Date:   Thu, 3 Sep 2020 18:51:17 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Nishanth Menon <nm@...com>, Rob Herring <robh+dt@...nel.org>,
        Tero Kristo <t-kristo@...com>
CC:     <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, Suman Anna <s-anna@...com>,
        <lokeshvutla@...com>, <grygorii.strashko@...com>, <nsekhar@...com>
Subject: Re: [PATCH V2 4/8] arm64: dts: ti: k3-am65*: Use generic clock for
 syscon clock names



On 9/3/20 6:30 PM, Nishanth Menon wrote:
> serdes and ehrpwm_tbclk nodes should be using clock@ naming for nodes
> following standard conventions of device tree (section 2.2.2 Generic
> Names recommendation in [1]).
> 
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
> 
> Suggested-by: Suman Anna <s-anna@...com>
> Signed-off-by: Nishanth Menon <nm@...com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@...com>
> Acked-by: Suman Anna <s-anna@...com>
> ---
> Change:
> v2:  added ehrpwm_tbclk based on review comments.
> v1: https://lore.kernel.org/linux-arm-kernel/20200901223059.14801-3-nm@ti.com/
> 
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index a2fc508e59a6..63a1299cb0b2 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -327,12 +327,12 @@
>  			reg = <0x00000210 0x4>;
>  		};
>  
> -		serdes0_clk: serdes_clk@...0 {
> +		serdes0_clk: clock@...0 {
>  			compatible = "syscon";
>  			reg = <0x00004080 0x4>;
>  		};
>  
> -		serdes1_clk: serdes_clk@...0 {
> +		serdes1_clk: clock@...0 {
>  			compatible = "syscon";
>  			reg = <0x00004090 0x4>;
>  		};
> @@ -349,7 +349,7 @@
>  			reg = <0x0000041e0 0x14>;
>  		};
>  
> -		ehrpwm_tbclk: syscon@...0 {
> +		ehrpwm_tbclk: clock@...0 {
>  			compatible = "ti,am654-ehrpwm-tbclk", "syscon";
>  			reg = <0x4140 0x18>;
>  			#clock-cells = <1>;
> 

Acked-by: Vignesh Raghavendra <vigneshr@...com>